(FM-2577) Minor SQL server connection building refactorings #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove erb template and the code that calls it. Should have been removed in a prior commit, but was accidentally left over.
|
Waiting for Travis-CI but 👍 |
| params = { | ||
| 'Provider' => 'SQLOLEDB.1', | ||
| 'User ID' => config['admin'], | ||
| 'Password' => config['pass'], |
There was a problem hiding this comment.
Missing Persist Security Info and tests failing as a result.
There was a problem hiding this comment.
Gotcha - will fixup test. Note that I removed Persist Security Info since it has been the default for a long time.
Iristyle
force-pushed
the
ticket/master/FM-2577-remove-sqlcmd-remnants
branch
4 times, most recently
from
a89119f to
ca24c1c
Compare
- Note that Persist Security Info = False was removed from the Connection String since it's already the default.
Iristyle
force-pushed
the
ticket/master/FM-2577-remove-sqlcmd-remnants
branch
from
ca24c1c to
01e6cb6
Compare
cyberious
added a commit
that referenced
this pull request
May 13, 2015
…lcmd-remnants (FM-2577) Minor SQL server connection building refactorings
| config = {'database' => 'master'}.merge(config) | ||
| # Open ADO connection to the SQL Server database | ||
| connection_string = "Provider=SQLOLEDB.1;" | ||
| connection_string << "Persist Security Info=False;" |
There was a problem hiding this comment.
I think this line was lost, never to be found again. @Iristyle @cyberious was that intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.